Skip to content

wayback.py: Fix undefined names discovered by ruff #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Jun 13, 2025

Please carefully review the change to server/views/apis/v1/items.py, as a change is needed, but the proposed change modifies the API calling convention.

% ruff check --output-format=github --select=E9,F63,F7,F82

Error: server/api/archive.py:342:25: F821 Undefined name `url`
Error: server/api/books.py:263:9: F821 Undefined name `self`
Error: server/api/books.py:264:23: F821 Undefined name `self`
Error: server/views/apis/v1/books.py:154:61: F821 Undefined name `access`
Error: server/views/apis/v1/books.py:154:76: F821 Undefined name `secret`
Error: server/views/apis/v1/items.py:38:21: F821 Undefined name `iid`
Error: server/views/apis/v1/wayback.py:33:13: F821 Undefined name `requests`
Error: Process completed with exit code 1.

https://docs.astral.sh/ruff

% ruff rule F821

undefined-name (F821)

Derived from the Pyflakes linter.

What it does

Checks for uses of undefined names.

Why is this bad?

An undefined name is likely to raise NameError at runtime.

Example

def double():
    return n * 2  # raises `NameError` if `n` is undefined when `double` is called

Use instead:

def double(n):
    return n * 2

Options

  • [target-version]: Can be used to configure which symbols Ruff will understand
    as being available in the builtins namespace.

References

cclauss added 4 commits June 13, 2025 08:19
% `ruff check --output-format=github --select=E9,F63,F7,F82`
```
Error: server/api/archive.py:342:25: F821 Undefined name `url`
Error: server/api/books.py:263:9: F821 Undefined name `self`
Error: server/api/books.py:264:23: F821 Undefined name `self`
Error: server/views/apis/v1/books.py:154:61: F821 Undefined name `access`
Error: server/views/apis/v1/books.py:154:76: F821 Undefined name `secret`
Error: server/views/apis/v1/items.py:38:21: F821 Undefined name `iid`
Error: server/views/apis/v1/wayback.py:33:13: F821 Undefined name `requests`
Error: Process completed with exit code 1.
```
https://docs.astral.sh/ruff
Fixes undefined names discovered by ruff.
% `ruff rule F821`
# undefined-name (F821)

Derived from the **Pyflakes** linter.

## What it does
Checks for uses of undefined names.

## Why is this bad?
An undefined name is likely to raise `NameError` at runtime.

## Example
```python
def double():
    return n * 2  # raises `NameError` if `n` is undefined when `double` is called
```

Use instead:
```python
def double(n):
    return n * 2
```

## Options
- [`target-version`]: Can be used to configure which symbols Ruff will understand
  as being available in the `builtins` namespace.

## References
- [Python documentation: Naming and binding](https://docs.python.org/3/reference/executionmodel.html#naming-and-binding)
@cclauss cclauss changed the title wayback.py: Fix undefined name requests used on line 34 wayback.py: Fix undefined names discovered by ruff Jun 13, 2025
@@ -31,7 +31,7 @@ def get(self, page=1, limit=100):
query=query, cursor=cursor, version=version)

@rest_api
def post(self):
def post(self, iid):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes the API calling convention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant